fix(enhanced): refactor hoisting plugins #3488
Merged
+215
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ScriptedAlchemy
changed the base branch from
remove-hoisted-runtime-experiment
to
main
ScriptedAlchemy
changed the base branch from
main
to
remove-hoisted-runtime-experiment
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ScriptedAlchemy
merged commit 89d35b0
into
remove-hoisted-runtime-experiment
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes across multiple files to improve the configuration and runtime behavior of the application. The most important changes include updates to the webpack configuration, enhancements to the Module Federation Plugin, and adjustments to the startup chunk dependencies.
Webpack Configuration Updates:
apps/manifest-demo/3009-webpack-provider/webpack.config.js: AddeddevMiddlewareconfiguration to write files to disk in development mode.apps/manifest-demo/webpack-host/webpack.config.js: Disabled the runtime option for theModuleFederationPlugin.apps/modernjs/modern.config.ts: Disabled the runtime option for theModuleFederationPlugin.Module Federation Plugin Enhancements:
packages/enhanced/src/lib/container/ContainerPlugin.ts: Removed the check for a single runtime chunk and always set the runtime option. [1] [2]packages/enhanced/src/lib/container/runtime/EmbedFederationRuntimePlugin.ts: Simplified the logic for handling startup calls and added proactive runtime requirements for chunks. [1] [2] [3]Startup Chunk Dependencies Adjustments:
packages/enhanced/src/lib/startup/MfStartupChunkDependenciesPlugin.ts: Added additional runtime requirements at both the tree and chunk levels, and customized the startup generation based on entry modules. [1] [2] [3] [4] [5] [6] [7]Miscellaneous Changes:
apps/modernjs/project.json: Corrected theoptionsfield indentation for thebuildandservetargets. [1] [2]package.json: Added the--skip-nx-cacheoption to theapp:manifest:devscript.packages/enhanced/test/ConfigTestCases.basictest.js: Added a basic test case forConfigTestCases.Related Issue
Types of changes
Checklist